Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 3127009: Convert infobar APIs to UTF-16. (Closed)

Created:
10 years, 4 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Paul Godavari, jam, brettw-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, stuartmorgan+watch_chromium.org, dhollowa
Visibility:
Public.

Description

Convert infobar APIs to UTF-16. The critical change is the base class in infobar_delegate.h. The remainder is just adapting all users to that change. I grepped for all instances of the three base functions whose types I changed to be more sure that I found all classes that tried to overload these functions. I sure wish C++ had an @Override annotation. :~( TEST=compiles BUG=23581 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56066

Patch Set 1 #

Patch Set 2 : works #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -234 lines) Patch
M chrome/browser/alternate_nav_url_fetcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/alternate_nav_url_fetcher.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/blocked_plugin_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/blocked_plugin_manager.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/browser_init.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/cocoa/infobar_controller.mm View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/cocoa/infobar_controller_unittest.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/cocoa/infobar_test_helper.h View 1 6 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/cocoa/keystone_infobar.mm View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/download/download_request_infobar_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_request_infobar_delegate.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/download/download_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crashed_extension_infobar.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/crashed_extension_infobar.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_infobar_delegate.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 1 chunk +5 lines, -3 lines 1 comment Download
M chrome/browser/extensions/theme_installed_infobar_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/theme_installed_infobar_delegate.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context.cc View 1 chunk +10 lines, -9 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/gtk/infobar_gtk.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/infobar_gtk.cc View 8 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/omnibox_search_hint.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/plugin_installer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/plugin_installer.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/printing/print_dialog_gtk.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ssl/ssl_policy_backend.cc View 6 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/tab_contents/infobar_delegate.h View 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/tab_contents/infobar_delegate.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 5 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_ssl_helper.cc View 3 chunks +10 lines, -7 lines 2 comments Download
M chrome/browser/views/infobars/infobars.cc View 1 6 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
10 years, 4 months ago (2010-08-13 17:41:34 UTC) #1
viettrungluu
10 years, 4 months ago (2010-08-13 19:22:03 UTC) #2
LGTM with tiny style nits.

http://codereview.chromium.org/3127009/diff/2001/3019
File chrome/browser/extensions/extension_install_ui.cc (right):

http://codereview.chromium.org/3127009/diff/2001/3019#newcode355
chrome/browser/extensions/extension_install_ui.cc:355:
l10n_util::GetStringFUTF16(IDS_EXTENSION_INSTALLED_HEADING,
Indent 2 more spaces (and below too, to align).

http://codereview.chromium.org/3127009/diff/2001/3035
File chrome/browser/tab_contents/tab_contents_ssl_helper.cc (right):

http://codereview.chromium.org/3127009/diff/2001/3035#newcode117
chrome/browser/tab_contents/tab_contents_ssl_helper.cc:117: void
ShowErrorInfoBar(const std::wstring& message) {
We'll leave converting this to another day. ;)

http://codereview.chromium.org/3127009/diff/2001/3035#newcode119
chrome/browser/tab_contents/tab_contents_ssl_helper.cc:119: new
SimpleAlertInfoBarDelegate(tab_, WideToUTF16(message), GetCertIcon(),
80 cols

Powered by Google App Engine
This is Rietveld 408576698