Issue 3126029: Move the chromium.Interval to chrome.Interval as part of the benchmarking...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3126029: Move the chromium.Interval to chrome.Interval as part of the benchmarking... (Closed)

Created:
10 years, 4 months ago by Mike Belshe

Modified:
9 years, 5 months ago

Reviewers:
tony, tc, ojan

CC:
chromium-reviews, pam+watch_chromium.org, Aaron Boodman, Erik does not do reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move the chromium.Interval to chrome.Interval as part of the benchmarking extension. This means that users will need to use --enable-benchmarking to access it. It really shouldn't be part of the exposed API. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57386

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : Missed a file #

Patch Set 5 : One more missing file!! #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -162 lines)			Patch
M	chrome/common/extensions/docs/examples/api/messaging/timer/popup.html	View	1 2 3 4	1 chunk	+77 lines, -71 lines	0 comments	Download
M	chrome/renderer/render_thread.cc	View	2 3 4	2 chunks	+0 lines, -3 lines	0 comments	Download
M	webkit/extensions/v8/benchmarking_extension.cc	View	1 2 3 4	4 chunks	+29 lines, -0 lines	0 comments	Download
D	webkit/extensions/v8/interval_extension.h	View	1 2 3 4	1 chunk	+0 lines, -22 lines	0 comments	Download
D	webkit/extensions/v8/interval_extension.cc	View	1 2 3 4	1 chunk	+0 lines, -58 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 2 3 4	1 chunk	+0 lines, -2 lines	0 comments	Download
M	webkit/support/test_webkit_client.cc	View	4	2 chunks	+0 lines, -3 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_webkit_init.cc	View		2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, thanks!

Expand Messages | Collapse Messages