Issue 3126013: Fix KeyBlockVerify() to take an explicit param for whether to use hash only.

Issue 3126013: Fix KeyBlockVerify() to take an explicit param for whether to use hash only. (Closed)

Created:
10 years, 4 months ago by Randall Spangler

Modified:
9 years, 7 months ago

Reviewers:
gauravsh

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://gitrw.chromium.org/vboot_reference.git

Visibility:
Public.

Description

Fix KeyBlockVerify() to take an explicit param for whether to use hash only. Fix VerifyMemberInside(). BUG=chrome-os-partner:703 TEST=make && make runtests

Patch Set 2 : Don't rename func #

Patch Set 3 : Fix one last typo #

Total comments: 4

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -65 lines)			Patch
M	firmware/lib/include/vboot_common.h	View	1	1 chunk	+2 lines, -2 lines	2 comments	Download
M	firmware/lib/vboot_common.c	View	1	4 chunks	+39 lines, -28 lines	2 comments	Download
M	firmware/lib/vboot_firmware.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	firmware/lib/vboot_kernel.c	View	1 2	2 chunks	+4 lines, -6 lines	0 comments	Download
M	firmware/linktest/main.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	firmware/version.c	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	host/lib/host_keyblock.c	View	1 2	3 chunks	+3 lines, -4 lines	0 comments	Download
M	tests/vboot_common3_tests.c	View	1	2 chunks	+21 lines, -17 lines	0 comments	Download
M	utility/dev_sign_file.c	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	utility/vbutil_firmware.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	utility/vbutil_kernel.c	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	utility/vbutil_keyblock.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gauravsh

lgtm http://codereview.chromium.org/3126013/diff/4001/5001 File firmware/lib/include/vboot_common.h (right): http://codereview.chromium.org/3126013/diff/4001/5001#newcode87 firmware/lib/include/vboot_common.h:87: * key [key]. If hash_only, uses only the ...

10 years, 4 months ago (2010-08-17 22:24:13 UTC) #2

Randall Spangler

10 years, 4 months ago (2010-08-17 22:43:55 UTC) #3

http://codereview.chromium.org/3126013/diff/4001/5001
File firmware/lib/include/vboot_common.h (right):

http://codereview.chromium.org/3126013/diff/4001/5001#newcode87
firmware/lib/include/vboot_common.h:87: * key [key].  If hash_only, uses only
the block checksum to verify
On 2010/08/17 22:24:13, gauravsh wrote:
> If hash_only is non-zero

Done.

http://codereview.chromium.org/3126013/diff/4001/5002
File firmware/lib/vboot_common.c (right):

http://codereview.chromium.org/3126013/diff/4001/5002#newcode195
firmware/lib/vboot_common.c:195: /* Check signature or hash, depending on
whether we provide a key. Note that
On 2010/08/17 22:24:13, gauravsh wrote:
> update comment to reflect the hash_only flag

Done.

Expand Messages | Collapse Messages