Issue 3125039: DOMUI: Several fixes for AutoFill page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3125039: DOMUI: Several fixes for AutoFill page. (Closed)

Created:
10 years, 4 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
dhg, csilv

CC:
chromium-reviews, dhg, ben+cc_chromium.org, arv (Not doing code reviews), dhollowa

Visibility:
Public.

Description

DOMUI: Several fixes for AutoFill page. * Properly enable and disable the Edit and Remove buttons based on select control state. * Modify the title of the address/CC overlays when pressing the 'Add address/CC' buttons. * Remove the ability to select multiple options. BUG=49094 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57129

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -35 lines)			Patch
M	chrome/browser/dom_ui/autofill_options_handler.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/autofill_edit_address_overlay.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/autofill_edit_address_overlay.js	View	1 chunk	+17 lines, -10 lines	0 comments	Download
M	chrome/browser/resources/options/autofill_edit_creditcard_overlay.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/autofill_edit_creditcard_overlay.js	View	2 chunks	+13 lines, -10 lines	0 comments	Download
M	chrome/browser/resources/options/autofill_options.html	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/autofill_options.js	View	5 chunks	+37 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages