Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 3125033: Mac: Re-fix hidden CoreAnimation plugins. (Closed)

Created:
10 years, 4 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews, John Grabowski, ben+cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Mac: Re-fix hidden CoreAnimation plugins. Stuart fixed this in http://codereview.chromium.org/2147002 and I regressed it in http://codereview.chromium.org/3010054 Note that the reduced testcase on the bug is still broken. Since it's broken in Safari too, that's a WebKit problem. BUG=52914, 51748 TEST=See bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57061

Patch Set 1 #

Patch Set 2 : real fix #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -39 lines) Patch
M chrome/browser/renderer_host/accelerated_surface_container_mac.h View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/accelerated_surface_container_mac.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/renderer_host/accelerated_surface_container_manager_mac.h View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc View 1 chunk +16 lines, -1 line 2 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 chunks +36 lines, -31 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
10 years, 4 months ago (2010-08-23 15:00:59 UTC) #1
stuartmorgan
LGTM http://codereview.chromium.org/3125033/diff/2001/3003 File chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc (right): http://codereview.chromium.org/3125033/diff/2001/3003#newcode118 chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc:118: if (!container) Might be clearer as just |return ...
10 years, 4 months ago (2010-08-23 16:02:44 UTC) #2
Nico
10 years, 4 months ago (2010-08-23 16:03:40 UTC) #3
Thanks!

http://codereview.chromium.org/3125033/diff/2001/3003
File chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc
(right):

http://codereview.chromium.org/3125033/diff/2001/3003#newcode118
chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc:118:
if (!container)
On 2010/08/23 16:02:44, stuartmorgan wrote:
> Might be clearer as just |return container && container->should_be_visible();|

Done.

Powered by Google App Engine
This is Rietveld 408576698