Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(2)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/extensions/manifest_tests/disallow_hybrid_1.json
Issue
3125031
:
Remove launch.container='window'. (Closed)
Base URL: git://codf21.jail/chromium.git
Patch Set:
Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/common/extensions/extension.cc
chrome/common/extensions/extension_manifests_unittest.cc
chrome/test/data/extensions/manifest_tests/browse_urls_default.json
chrome/test/data/extensions/manifest_tests/browse_urls_valid.json
chrome/test/data/extensions/manifest_tests/disallow_hybrid_1.json
chrome/test/data/extensions/manifest_tests/disallow_hybrid_2.json
chrome/test/data/extensions/manifest_tests/launch_fullscreen.json
chrome/test/data/extensions/manifest_tests/launch_fullscreen_invalid.json
chrome/test/data/extensions/manifest_tests/launch_height.json
chrome/test/data/extensions/manifest_tests/launch_height_negative.json
chrome/test/data/extensions/manifest_tests/launch_width.json
chrome/test/data/extensions/manifest_tests/launch_width_negative.json
chrome/test/data/extensions/manifest_tests/valid_app.json
chrome/test/data/extensions/manifest_tests/web_urls_default.json
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/test/data/extensions/manifest_tests/browse_urls_valid.json
('k') |
chrome/test/data/extensions/manifest_tests/disallow_hybrid_2.json »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 {
1 {
2 "name": "test",
2 "name": "test",
3 "version": "1",
3 "version": "1",
4 "app": {
4 "app": {
5 "urls": [
5 "urls": [
6 "http://www.google.com/mail/",
6 "http://www.google.com/mail/",
7 "http://www.google.com/foobar/"
7 "http://www.google.com/foobar/"
8 ],
8 ],
9 "launch": {
9 "launch": {
10
"container": "window",
11 "web_url": "http://www.google.com/mail/"
10 "web_url": "http://www.google.com/mail/"
12 }
11 }
13 },
12 },
14 "permissions": [
13 "permissions": [
15 "notifications"
14 "notifications"
16 ],
15 ],
17 "browser_action": {}
16 "browser_action": {}
18 }
17 }
OLD
NEW
« no previous file with comments
|
« chrome/test/data/extensions/manifest_tests/browse_urls_valid.json
('k') |
chrome/test/data/extensions/manifest_tests/disallow_hybrid_2.json »
('j') |
no next file with comments »
Issue 3125031: Remove launch.container='window'. (Closed)
Created 10 years, 4 months ago by Aaron Boodman
Modified 9 years, 6 months ago
Reviewers: asargent_no_longer_on_chrome, Bons
Base URL: git://codf21.jail/chromium.git
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
