Issue 3125017: Modify to work with cros_workon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3125017: Modify to work with cros_workon. (Closed)

Created:
10 years, 4 months ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
sosa, rtc, anush

CC:
chromium-os-reviews_chromium.org

Base URL:
http://src.chromium.org/git/dev-util.git

Visibility:
Public.

Description

Modify to work with cros_workon. This fixes bug 5686 where the stable version of the package gets installed when the 9999 is unmasked. BUG=5868 TEST=Verified that 9999 version of the package now gets installed. Verified the following sequence: 1. verified stable gets installed 2. start power_manager 3. verified 9999 gets installed 4. stop power_manager 5. verified that stable gets installed Change-Id: I26d600692e0e359d6ac153cdbca70ac5ae5d420f

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	devserver.py	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	gmerge	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sosa

LGTM if answer to question is no ... + nit http://codereview.chromium.org/3125017/diff/1/3 File gmerge (right): http://codereview.chromium.org/3125017/diff/1/3#newcode38 ...

10 years, 4 months ago (2010-08-17 20:55:34 UTC) #2

Mandeep Singh Baines

10 years, 4 months ago (2010-08-17 21:03:42 UTC) #3

On 2010/08/17 20:55:34, sosa wrote:
> LGTM if answer to question is no ... + nit
> 
> http://codereview.chromium.org/3125017/diff/1/3
> File gmerge (right):
> 
> http://codereview.chromium.org/3125017/diff/1/3#newcode38
> gmerge:38: # Delete the local binary package cache
> nit: period at end.
> 

Fixed.

> Also, is there a more elegant way to do this ..i.e just instruct portage not
to
> cache the packages?  I looked through the man pages for make.conf and emerge
but
> saw nothing that seemed to do this.

Yeah, I couldn't find anything either.

Pushing.

Expand Messages | Collapse Messages