Issue 3125011: ARM: Ensure that we are not in a spilled scope when calling...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3125011: ARM: Ensure that we are not in a spilled scope when calling... (Closed)

Created:
10 years, 4 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Ensure that we are not in a spilled scope when calling Load() or constructing a reference. Committed: http://code.google.com/p/v8/source/detail?r=5270

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -28 lines)			Patch
	M	src/arm/codegen-arm.cc	View		20 chunks	+35 lines, -28 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

10 years, 4 months ago (2010-08-16 07:15:35 UTC) #2

LGTM

Should this mention issue 815?
Is it easy to make a regression test for
http://code.google.com/p/v8/issues/detail?id=815?

http://codereview.chromium.org/3125011/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/3125011/diff/1/2#newcode2609
src/arm/codegen-arm.cc:2609: STATIC_ASSERT(StackHandlerConstants::kNextOffset ==
0);
Maybe add the r0 comment here as well.

Expand Messages | Collapse Messages