Fix duplicate Dependency that appeared by switching from a flat list to a tree.

Fix duplicate Dependency that appeared by switching from a flat list to a tree.

Instead of keeping the reference information in the parent, note for each Dependency if it should be processed with self.should_process. I had to hack a bit with the hooks to also enforce recursion_limit() to keep the old behavior, otherwise From() could cause hooks to run that weren't run before.

BUG=50015
TEST=hooks are run properly. Tested with webkit and pagespeed and buildbot master, fixes running the same checkout multiple times.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55895

[bradn, 2010-08-12 16:38:32]

http://codereview.chromium.org/3124017/diff/2001/3001
File gclient.py (right):

http://codereview.chromium.org/3124017/diff/2001/3001#newcode430
gclient.py:430: #should_process = False
Was this meant to be commented out?

[M-A Ruel, 2010-08-12 16:40:28]

yes but I'll just remove it.

On-screen keyboard adds typos to my usual grammar dysfunction.

Le 12 août 2010 12:38, <bradnelson@google.com> a écrit :
>
> http://codereview.chromium.org/3124017/diff/2001/3001
> File gclient.py (right):
>
> http://codereview.chromium.org/3124017/diff/2001/3001#newcode430
> gclient.py:430: #should_process = False
> Was this meant to be commented out?
>
> http://codereview.chromium.org/3124017/show

[bradn, 2010-08-12 16:48:13]

LGTM