Don't install autotest bits to the image.

Don't install autotest bits to the image.

Autotest installs stuff to the image via ssh, so there's no need to include
all of this stuff to the image. This saves disk space. Note that
/usr/local/autotest-chrome is currently already excluded from the image
because of a hack in the chrome ebuild, and that /usr/local/autotest is
usually also excluded from the image because autotest is not included
as a dependency of any packages that are installed.

In the factory setting, it looks like the factory has its own code for
installing autotests via rsync. Presumbably, if the factory tests are
managing the autotest directly, they won't want emerge mucking with the
directory as well on the image. Currently, emerge doesn't muck with the same
directory, but we probably want to ensure that it doesn't start doing that in
future to ensure sanity.

TEST=Built images. Modded for factory test. Verified that (a) build directory contains autotests, (b) regular images do not contain autotests; and (c) images modified for factory test do contain autotests

[zel, 2010-08-11 19:43:15]

LGTM

[davidjames, 2010-08-11 21:16:13]

Eric Li, Nick Sanders, could you take a look at this patch? I want to make sure
this doesn't break anything autotest-related.

[ericli, 2010-08-11 21:25:43]

LGTM.

But I would invite petkov@ for an extra look.

Not sure if the removal of /usr/local/autotest will affect HWQ. I am not sure
about his documented process.

[petkov, 2010-08-11 21:31:48]

LGTM assuming you still get /usr/local/autotest installed in the sysroot (so
that archive_build, archive_hwqual, etc.) can pick it up.

[zbehan, 2010-08-11 23:29:14]

It is installed into sysroot (always). Install mask, as I understand it, is
for building the image, and filtering files from it.

Also, LGTM :)

On Wed, Aug 11, 2010 at 2:31 PM, <petkov@chromium.org> wrote:

> LGTM assuming you still get /usr/local/autotest installed in the sysroot
> (so
> that archive_build, archive_hwqual, etc.) can pick it up.
>
>
>
>
> http://codereview.chromium.org/3124010/show
>