Issue 3124002: [Mac] Insert the Update Chrome item to existing Wrench menus when notified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3124002: [Mac] Insert the Update Chrome item to existing Wrench menus when notified. (Closed)

Created:
10 years, 4 months ago by Robert Sesek

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

[Mac] Insert the Update Chrome item to existing Wrench menus when notified. BUG=50659 TEST=Wait for upgrade. Get yellow ball on Wrench menu. Open menu, see Update Chrome item. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55568

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename method #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -0 lines)			Patch
M	chrome/browser/cocoa/toolbar_controller.mm	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/wrench_menu_controller.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/wrench_menu_controller.mm	View	1	3 chunks	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

I tried to write a test. But then I realized that the WrenchMenuModel isn't test ...

10 years, 4 months ago (2010-08-09 21:50:47 UTC) #1

pink (ping after 24hrs)

10 years, 4 months ago (2010-08-10 13:10:50 UTC) #2

lgtm

http://codereview.chromium.org/3124002/diff/1/4
File chrome/browser/cocoa/wrench_menu_controller.mm (right):

http://codereview.chromium.org/3124002/diff/1/4#newcode128
chrome/browser/cocoa/wrench_menu_controller.mm:128: -
(void)insertUpdateChromeItem {
maybe rename this -insertUpdateAvailableItem so we don't have more uses of the
product name in code (since only google can use "chrome")?

Expand Messages | Collapse Messages