Issue 3122040: Don't run URLRequestTest under ThreadSanitizer on Windows...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3122040: Don't run URLRequestTest under ThreadSanitizer on Windows... (Closed)

Created:
10 years, 4 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, cbentzel+watch_chromium.org, Timur Iskhodzhanov, Alexander Potapenko, darin-cc_chromium.org, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Don't run URLRequestTest under ThreadSanitizer on Windows BUG=53304 TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57318

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	net/data/valgrind/net_unittests.gtest-tsan_win32.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years, 4 months ago (2010-08-25 11:20:16 UTC) #2

LGTM

On Wed, Aug 25, 2010 at 3:15 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Don't run URLRequestTest under ThreadSanitizer on Windows
> BUG=53304
> TBR=glider
>
> Please review this at http://codereview.chromium.org/3122040/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     net/data/valgrind/net_unittests.gtest-tsan_win32.txt
>
>
> Index: net/data/valgrind/net_unittests.gtest-tsan_win32.txt
> ===================================================================
> --- net/data/valgrind/net_unittests.gtest-tsan_win32.txt        (revision
> 57182)
> +++ net/data/valgrind/net_unittests.gtest-tsan_win32.txt        (working
> copy)
> @@ -11,6 +11,9 @@
>  # See http://crbug.com/46647
>  DiskCacheBackendTest.*
>
> +# See http://crbug.com/53304
> +URLRequestTest.*
> +
>  # See http://crbug.com/47836
>  ClientSocketPoolBaseTest.CancelPendingSocketAtSocketLimit
>
>
>
>

Expand Messages | Collapse Messages