Issue 3122032: Remove suppressions for bug 52808 (leak in HostContentSettingsMapTest.ResourceIdentifierPrefs)

Issue 3122032: Remove suppressions for bug 52808 (leak in HostContentSettingsMapTest.ResourceIdentifierPrefs) (Closed)

Created:
10 years, 4 months ago by Bernhard Bauer

Modified:
9 years, 7 months ago

Reviewers:
Alexander Potapenko, Timur Iskhodzhanov, Hironori Bono

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Remove suppressions for bug 52808 (leak in HostContentSettingsMapTest.ResourceIdentifierPrefs) This should be fixed by http://crrev.com/56831, no? BUG=52808 TEST=valgrind bots stay happy Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56875

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -21 lines)			Patch
	M	tools/heapcheck/suppressions.txt	View		1 chunk	+0 lines, -10 lines	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years, 4 months ago (2010-08-20 12:31:45 UTC) #2

LGTM

On Fri, Aug 20, 2010 at 4:10 PM,  <bauerb@chromium.org> wrote:
> Reviewers: Alexander Potapenko, hbono, Timur Iskhodzhanov,
>
> Message:
> please review.
>
> Description:
> Remove suppressions for bug 52808 (leak in
> HostContentSettingsMapTest.ResourceIdentifierPrefs)
>
> This should be fixed by http://crrev.com/56831, no?
>
> BUG=52808
> TEST=valgrind bots stay happy
>
> Please review this at http://codereview.chromium.org/3122032/show
>
> SVN Base: git://codf21.jail/chromium.git
>
> Affected files:
>  M tools/heapcheck/suppressions.txt
>  M tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/heapcheck/suppressions.txt
> diff --git a/tools/heapcheck/suppressions.txt
> b/tools/heapcheck/suppressions.txt
> index
>
57250afb6b443fd1fa65e9ca0ef360e9f0994abe..42cd4332686d7d33e5214292ce5d8b57c5ebc3e9
> 100644
> --- a/tools/heapcheck/suppressions.txt
> +++ b/tools/heapcheck/suppressions.txt
> @@ -957,13 +957,3 @@
>    fun:Callback1::Type* NewCallback
>    fun:PrefValueStoreTest_TestConcurrentPolicyRefresh_Test::TestBody
>  }
> -{
> -   bug_52808
> -   Heapcheck:Leak
> -   ...
> -   fun:base::JSONReader::BuildValue
> -   fun:base::JSONReader::JsonToValue
> -   fun:base::JSONReader::ReadAndReturnError
> -   fun:base::JSONReader::Read
> -   fun:::HostContentSettingsMapTest_ResourceIdentifierPrefs_Test::TestBody
> -}
> Index: tools/valgrind/memcheck/suppressions.txt
> diff --git a/tools/valgrind/memcheck/suppressions.txt
> b/tools/valgrind/memcheck/suppressions.txt
> index
>
e8963befe497ce01bad35c5dbec8428421101ea6..c988c1c06346b60f754dd883e0e3ddc025cab919
> 100644
> --- a/tools/valgrind/memcheck/suppressions.txt
> +++ b/tools/valgrind/memcheck/suppressions.txt
> @@ -4157,17 +4157,6 @@
>    fun:_ZN20GoogleURLTrackerTest20CreateRequestContextEv
>  }
>  {
> -   bug_52828
> -   Memcheck:Leak
> -   fun:_Znw*
> -   ...
> -   fun:_ZN4base10JSONReader10BuildValueEb
> -   fun:_ZN4base10JSONReader11JsonToValueERKSsbb
> -   fun:_ZN4base10JSONReader18ReadAndReturnErrorERKSsbPiPSs
> -   fun:_ZN4base10JSONReader4ReadERKSsb
> -
> fun:_ZN81_GLOBAL__N_chrome_browser_host_content_settings_map_unittest.cc*
> -}
> -{
>    bug_52831
>    Memcheck:Leak
>    fun:_Znw*
>
>
>

Expand Messages | Collapse Messages