Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 3122025: Decrease the DST cache increment to take into account the suspension... (Closed)

Created:
10 years, 4 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Decrease the DST cache increment to take into account the suspension of DST in Egypt during Ramadan 2010. Committed: http://code.google.com/p/v8/source/detail?r=5289

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M src/date.js View 1 4 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
10 years, 4 months ago (2010-08-18 06:47:20 UTC) #1
Kasper Lund
LGTM. http://codereview.chromium.org/3122025/diff/1/2 File src/date.js (right): http://codereview.chromium.org/3122025/diff/1/2#newcode179 src/date.js:179: cache.increment = 19 * msPerDay; Maybe have the ...
10 years, 4 months ago (2010-08-18 06:53:11 UTC) #2
Mads Ager (chromium)
10 years, 4 months ago (2010-08-18 07:00:50 UTC) #3
http://codereview.chromium.org/3122025/diff/1/2
File src/date.js (right):

http://codereview.chromium.org/3122025/diff/1/2#newcode179
src/date.js:179: cache.increment = 19 * msPerDay;
On 2010/08/18 06:53:12, Kasper Lund wrote:
> Maybe have the a cache.initialIncrement or initial_increment so we don't have
> the same value in 3 places?

Done.

Powered by Google App Engine
This is Rietveld 408576698