Initial change that allows to disable bookmarks in Chrome for Chrome OS (BWSI...

chrome/app/chrome_dll_main.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(port): the ifdefs in here are a first step towards trying to determine
 // the correct abstraction for all the OS functionality required at this
 // stage of process initialization. It should not be taken as a final
 // abstraction.
 
 #include "build/build_config.h"
@@ skipping 554 matching lines @@
     singleton_command_line->AppendSwitch(switches::kInternalNaCl);
     singleton_command_line->AppendSwitch(switches::kEnableGPUPlugin);
   }
 
 #if defined(OS_CHROMEOS)
   if (parsed_command_line.HasSwitch(switches::kBWSI)) {
     // Disable sync and extensions if we're in "browse without sign-in" mode.
     CommandLine* singleton_command_line = CommandLine::ForCurrentProcess();
     singleton_command_line->AppendSwitch(switches::kDisableSync);
     singleton_command_line->AppendSwitch(switches::kDisableExtensions);
+    singleton_command_line->AppendSwitch(switches::kDisableBookmarks);

[sky, 2010/08/17 17:58:39]

How come we're modifying the command line switches for these? Why not just set a
boolean some where? I would be inclined to modify defaults for these sort of
things.

[Dmitry Polukhin, 2010/08/18 08:37:51]

As far as I understand we need to modify switches to easy propagate them to all
child Chrome processes. Having this as a command line option has advantage that
it can be activated very easy and not only together with BWSI.

   }
 #endif
 
   base::ProcessId browser_pid = base::GetCurrentProcId();
   if (SubprocessIsBrowserChild(process_type)) {
 #if defined(OS_WIN)
     std::string channel_name =
         parsed_command_line.GetSwitchValueASCII(switches::kProcessChannelID);
 
     int browser_pid_int;
@@ skipping 328 matching lines @@
 
   logging::CleanupChromeLogging();
 
 #if defined(OS_MACOSX) && defined(GOOGLE_CHROME_BUILD)
   // TODO(mark): See the TODO(mark) above at InitCrashReporter.
   DestructCrashReporter();
 #endif  // OS_MACOSX && GOOGLE_CHROME_BUILD
 
   return rv;
 }