Remove ltp from set of tests to build.

Remove ltp from set of tests to build.

The ltp tests don't pass, and take a long time to build. Once they pass,
it'll make sense to add them back. But otherwise, no point waiting for their
long build process to complete.

BUG=none
TEST=Run build_packages --withautotest

[ericli, 2010-08-12 21:32:08]

LGTM.

On Thu, Aug 12, 2010 at 2:21 PM, <davidjames@chromium.org> wrote:

> Reviewers: kmixter1,
>
> Description:
> Remove ltp from set of tests to build.
>
> The ltp tests don't pass, and take a long time to build. Once they pass,
> it'll make sense to add them back. But otherwise, no point waiting for
> their
> long build process to complete.
>
> BUG=none
> TEST=Run build_packages --withautotest
>
> Please review this at http://codereview.chromium.org/3121010/show
>
> SVN Base: ssh://git@chromiumos-git/crosutils.git
>
> Affected files:
>  M autotest
>
>
> Index: autotest
> diff --git a/autotest b/autotest
> index
>
1ab04e3083485d3dfb11dfe88170acdb501ad839..e5065950d718397d2c9d617061ab330f9b112b4e
> 100755
> --- a/autotest
> +++ b/autotest
> @@ -155,7 +155,7 @@ def build_autotest(options):
>   else:
>     blacklist = []
>
> -  all_tests =
> ('compilebench,dbench,disktest,fsx,hackbench,iperf,ltp,netperf2,'
> +  all_tests =
> ('compilebench,dbench,disktest,fsx,hackbench,iperf,netperf2,'
>                'netpipe,unixbench')
>   site_tests = '../third_party/autotest/files/client/site_tests'
>   for site_test in os.listdir(site_tests):
>
>
>


-- 
Eric Li
李咏竹
Google Kirkland

[zbehan, 2010-08-12 21:32:58]

Could you also remove them from the list in the autotests-tests-9999.ebuild
?

On Thu, Aug 12, 2010 at 2:21 PM, <davidjames@chromium.org> wrote:

> Reviewers: kmixter1,
>
> Description:
> Remove ltp from set of tests to build.
>
> The ltp tests don't pass, and take a long time to build. Once they pass,
> it'll make sense to add them back. But otherwise, no point waiting for
> their
> long build process to complete.
>
> BUG=none
> TEST=Run build_packages --withautotest
>
> Please review this at http://codereview.chromium.org/3121010/show
>
> SVN Base: ssh://git@chromiumos-git/crosutils.git
>
> Affected files:
>  M autotest
>
>
> Index: autotest
> diff --git a/autotest b/autotest
> index
>
1ab04e3083485d3dfb11dfe88170acdb501ad839..e5065950d718397d2c9d617061ab330f9b112b4e
> 100755
> --- a/autotest
> +++ b/autotest
> @@ -155,7 +155,7 @@ def build_autotest(options):
>   else:
>     blacklist = []
>
> -  all_tests =
> ('compilebench,dbench,disktest,fsx,hackbench,iperf,ltp,netperf2,'
> +  all_tests =
> ('compilebench,dbench,disktest,fsx,hackbench,iperf,netperf2,'
>                'netpipe,unixbench')
>   site_tests = '../third_party/autotest/files/client/site_tests'
>   for site_test in os.listdir(site_tests):
>
>
>

[zbehan, 2010-08-12 21:35:31]

Or....disable them, ie. change them to nothing instead of +.

On Thu, Aug 12, 2010 at 2:32 PM, Zdenek Behan <zbehan@chromium.org> wrote:

> Could you also remove them from the list in the autotests-tests-9999.ebuild
> ?
>
> On Thu, Aug 12, 2010 at 2:21 PM, <davidjames@chromium.org> wrote:
>
>> Reviewers: kmixter1,
>>
>> Description:
>> Remove ltp from set of tests to build.
>>
>> The ltp tests don't pass, and take a long time to build. Once they pass,
>> it'll make sense to add them back. But otherwise, no point waiting for
>> their
>> long build process to complete.
>>
>> BUG=none
>> TEST=Run build_packages --withautotest
>>
>> Please review this at http://codereview.chromium.org/3121010/show
>>
>> SVN Base: ssh://git@chromiumos-git/crosutils.git
>>
>> Affected files:
>>  M autotest
>>
>>
>> Index: autotest
>> diff --git a/autotest b/autotest
>> index
>>
1ab04e3083485d3dfb11dfe88170acdb501ad839..e5065950d718397d2c9d617061ab330f9b112b4e
>> 100755
>> --- a/autotest
>> +++ b/autotest
>> @@ -155,7 +155,7 @@ def build_autotest(options):
>>   else:
>>     blacklist = []
>>
>> -  all_tests =
>> ('compilebench,dbench,disktest,fsx,hackbench,iperf,ltp,netperf2,'
>> +  all_tests =
>> ('compilebench,dbench,disktest,fsx,hackbench,iperf,netperf2,'
>>                'netpipe,unixbench')
>>   site_tests = '../third_party/autotest/files/client/site_tests'
>>   for site_test in os.listdir(site_tests):
>>
>>
>>
>

[kmixter1, 2010-08-12 22:48:56]

LGTM

On Thu, Aug 12, 2010 at 2:21 PM,  <davidjames@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Description:
> Remove ltp from set of tests to build.
>
> The ltp tests don't pass, and take a long time to build. Once they pass,
> it'll make sense to add them back. But otherwise, no point waiting for their
> long build process to complete.
>
> BUG=none
> TEST=Run build_packages --withautotest
>
> Please review this at http://codereview.chromium.org/3121010/show
>
> SVN Base: ssh://git@chromiumos-git/crosutils.git
>
> Affected files:
>  M autotest
>
>
> Index: autotest
> diff --git a/autotest b/autotest
> index
>
1ab04e3083485d3dfb11dfe88170acdb501ad839..e5065950d718397d2c9d617061ab330f9b112b4e
> 100755
> --- a/autotest
> +++ b/autotest
> @@ -155,7 +155,7 @@ def build_autotest(options):
>   else:
>     blacklist = []
>
> -  all_tests =
> ('compilebench,dbench,disktest,fsx,hackbench,iperf,ltp,netperf2,'
> +  all_tests = ('compilebench,dbench,disktest,fsx,hackbench,iperf,netperf2,'
>                'netpipe,unixbench')
>   site_tests = '../third_party/autotest/files/client/site_tests'
>   for site_test in os.listdir(site_tests):
>
>
>