Issue 3120022: Widen the suppression for bug 52834 once again, suppress a memory leak in Ext...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3120022: Widen the suppression for bug 52834 once again, suppress a memory leak in Ext... (Closed)

Created:
10 years, 4 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Widen the suppression for bug 52834 once again, suppress a memory leak in ExtensionProxyUITest.Uninstall BUG=52834, 52837 TBR=glider TEST=./tools/valgrind/waterfall.sh match -> "Congratulations! All reports are suppressed!" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56847

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		2 chunks	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

10 years, 4 months ago (2010-08-20 13:34:35 UTC) #2

LGTM

On Fri, Aug 20, 2010 at 3:23 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Widen the suppression for bug 52834 once again, suppress a memory leak in
> ExtensionProxyUITest.Uninstall
> BUG=52834,52837
> TBR=glider
> TEST=./tools/valgrind/waterfall.sh match -> "Congratulations! All reports
> are
> suppressed!"
>
> Please review this at http://codereview.chromium.org/3120022/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> ===================================================================
> --- tools/valgrind/memcheck/suppressions.txt    (revision 56845)
> +++ tools/valgrind/memcheck/suppressions.txt    (working copy)
> @@ -4185,10 +4185,6 @@
>    Memcheck:Leak
>    fun:_Znw*
>    ...
> -   fun:_ZN5IDMapIN3IPC7Channel8ListenerEL23IDMapOwnershipSemantics0EEC1Ev
> -   fun:_ZN17RenderProcessHostC2EP7Profile
> -   ...
> -   fun:_ZN21MockRenderProcessHostC1EP7Profile
>    fun:_ZNK28MockRenderProcessHostFactory23CreateRenderProcessHostEP7Profile
>    fun:_ZN12SiteInstance10GetProcessEv
>    fun:_ZN14RenderViewHostC2EP12SiteInstanceP22RenderViewHostDelegateix
> @@ -4215,3 +4211,14 @@
>    fun:event_process_active
>    fun:event_base_loop
>  }
> +{
> +   bug_52837
> +   Memcheck:Leak
> +   fun:_Znw*
> +   ...
> +
>
fun:_ZNSt3mapISs8FilePathSt4lessISsESaISt4pairIKSsS0_EEE6insertESt17_Rb_tree_iteratorIS5_ERKS5_
> +   fun:_ZNSt3mapISs8FilePathSt4lessISsESaISt4pairIKSsS0_EEEixERS4_
> +   fun:_ZN17ExtensionsService15UnloadExtensionERKSs
> +   fun:_ZN17ExtensionsService18UninstallExtensionERKSsb
> +   fun:_ZN18AutomationProvider18UninstallExtensionEiPb
> +}
>
>
>

Expand Messages | Collapse Messages