Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3120021: FBTF: Header cleanup in chrome/common part 2. The majority of the changed files (Closed)

Created:
10 years, 4 months ago by James Hawkins
Modified:
9 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, Paul Godavari, ben+cc_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., jam, Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org, John Grabowski
Visibility:
Public.

Description

FBTF: Header cleanup in chrome/common part 2. The majority of the changed files just added notification_observer.h. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56824

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Mac fixes. #

Patch Set 4 : Stupid msvc++. #

Patch Set 5 : Win fix. #

Patch Set 6 : Win fix 2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -15 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup_model.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autocomplete/keyword_provider.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cert_store.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_plugin_browsing_context.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/theme_install_bubble_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/debugger/devtools_window.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/app_launcher_handler.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/ntp_resource_cache.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/options_ui.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/execute_code_in_tab_function.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_accessibility_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_bookmarks_module.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_cookies_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_popup_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_pref_store.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_process_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/user_script_listener.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/user_script_master.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/find_bar_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/google_url_tracker.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/collected_cookies_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/content_setting_bubble_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/info_bubble_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/infobar_container_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/tab_contents_container_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/tabs/dragged_tab_controller_gtk.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/history/in_memory_history_backend.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/idbbindingutilities_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/importer/importer.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/intranet_redirect_detector.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/mach_broker_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/modal_html_dialog_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/pref_notifier.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/pref_set_observer_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/printing/print_job.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/printing/print_job_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/printing/print_view_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profile_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/safe_browsing_resource_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/repost_form_warning_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url_model.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/collected_cookies_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/content_setting_bubble_contents.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/infobars/infobar_container.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_container.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/tabs/dragged_tab_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/theme_install_bubble_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/worker_host/message_port_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/zygote_main_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_plugin_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/notification_observer_mock.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/notification_registrar.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/common/notification_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/notification_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/notification_service_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/page_zoom.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/pepper_plugin_registry.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/plugin_group.h View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/common/plugin_group.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/process_watcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/property_bag.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/property_bag.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/serialized_script_value.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/common/serialized_script_value.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/socket_stream_dispatcher.h View 1 chunk +13 lines, -3 lines 0 comments Download
M chrome/common/socket_stream_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/blocked_plugin.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/test_notification_tracker.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/utility/utility_thread.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
James Hawkins
10 years, 4 months ago (2010-08-19 22:14:03 UTC) #1
Elliot Glaysher
10 years, 4 months ago (2010-08-19 22:18:16 UTC) #2 
LGTM, if it passes the compile on windows (I don't know if stdint.h on win
defined uniptr_t)

Powered by Google App Engine
This is Rietveld 408576698