Move FileDescriptorGetInode() and FindProcessHoldingSocket() into base/linux_...

Move FileDescriptorGetInode() and FindProcessHoldingSocket() into base/linux_util.cc. Reimplement FileDescriptorGetInode().

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30433

[agl, 2009-10-23 17:46:35]

LGTM if you fix a couple of nits.

http://codereview.chromium.org/312002/diff/1/3
File base/linux_util.cc (right):

http://codereview.chromium.org/312002/diff/1/3#newcode98
Line 98: const char kSocketLinkPrefix[] = "socket:[";
static

http://codereview.chromium.org/312002/diff/1/3#newcode105
Line 105: bool ProcPathGetInode(uint64_t* inode_out, const char* path, bool log
= false) {
ino_t

http://codereview.chromium.org/312002/diff/1/3#newcode256
Line 256: bool FileDescriptorGetInode(uint64_t* inode_out, int fd) {
ino_t

http://codereview.chromium.org/312002/diff/1/3#newcode270
Line 270: bool FindProcessHoldingSocket(pid_t* pid_out, uint64_t socket_inode) {
ino_t

http://codereview.chromium.org/312002/diff/1/3#newcode296
Line 296: if (snprintf(buf, sizeof(buf), "/proc/%d/fd", current_pid) < 0)
snprintf does not return what you think it does. In this case, you can get away
with not checking the return value since the length of output must fit in 256
bytes.

http://codereview.chromium.org/312002/diff/1/3#newcode303
Line 303: if (snprintf(buf, sizeof(buf), "/proc/%d/fd/%s", current_pid,
Again, snprintf doesn't return -1 on error. Check for >= sizeof(buf) as the
error condition.

http://codereview.chromium.org/312002/diff/1/3#newcode308
Line 308: uint64_t fd_inode;
ino_t

http://codereview.chromium.org/312002/diff/1/2
File base/linux_util.h (right):

http://codereview.chromium.org/312002/diff/1/2#newcode57
Line 57: bool FileDescriptorGetInode(uint64_t* inode_out, int fd);
ino_t for the type of an inode.

http://codereview.chromium.org/312002/diff/1/2#newcode61
Line 61: bool FindProcessHoldingSocket(pid_t* pid_out, uint64_t socket_inode);
ino_t

[Lei Zhang, 2009-10-27 21:21:14]

Done.

[agl, 2009-10-27 21:24:30]

LGTM