Put direct code pointers into JSFunction objects. This is a first step...

Put direct code pointers into JSFunction objects. This is a first step
in allowing more flexible compilation and to simplify builtins lookup. 

This changes a number of places where code objects are assigned to
SharedFunctionInfo objects to also assign this code object to the
JSFunction. In addition, the code flushing is changed slightly to
accomodate this (we need to flush the code from functions pointing to
SharedFunctionInfo objects that has already been flushed).



Committed: http://code.google.com/p/v8/source/detail?r=5233

[Kasper Lund, 2010-08-11 07:50:03]

LGTM.

http://codereview.chromium.org/3120006/diff/16001/17007
File src/handles.cc (right):

http://codereview.chromium.org/3120006/diff/16001/17007#newcode778
src/handles.cc:778: CompilationInfo info(function, 0, receiver);
Indentation is off here.

http://codereview.chromium.org/3120006/diff/16001/17008
File src/heap.cc (right):

http://codereview.chromium.org/3120006/diff/16001/17008#newcode2466
src/heap.cc:2466: 
Extra newline between the functions.

http://codereview.chromium.org/3120006/diff/16001/17008#newcode2468
src/heap.cc:2468: SharedFunctionInfo* function_info = function->shared();
I would call this shared_info instead of function_info.

http://codereview.chromium.org/3120006/diff/16001/17008#newcode2470
src/heap.cc:2470: // Special handling if the function and sharedfunctioninfo
objects
sharedfunctioninfo => shared info

http://codereview.chromium.org/3120006/diff/16001/17008#newcode2474
src/heap.cc:2474: // we flush the function if posible.
posible => possible.

http://codereview.chromium.org/3120006/diff/16001/17008#newcode2501
src/heap.cc:2501: // Check stack and archived threads for the code
Terminate comment with .

http://codereview.chromium.org/3120006/diff/16001/17008#newcode2520
src/heap.cc:2520: JSFunction* jsfunction = JSFunction::cast(obj);
jsfunction => function

[Rico, 2010-08-11 08:12:43]

http://codereview.chromium.org/3120006/diff/16001/17007
File src/handles.cc (right):

http://codereview.chromium.org/3120006/diff/16001/17007#newcode778
src/handles.cc:778: CompilationInfo info(function, 0, receiver);
On 2010/08/11 07:50:03, Kasper Lund wrote:
> Indentation is off here.

Done.

http://codereview.chromium.org/3120006/diff/16001/17008
File src/heap.cc (right):

http://codereview.chromium.org/3120006/diff/16001/17008#newcode2466
src/heap.cc:2466: 
On 2010/08/11 07:50:03, Kasper Lund wrote:
> Extra newline between the functions.

Done.

http://codereview.chromium.org/3120006/diff/16001/17008#newcode2468
src/heap.cc:2468: SharedFunctionInfo* function_info = function->shared();
On 2010/08/11 07:50:03, Kasper Lund wrote:
> I would call this shared_info instead of function_info.

Done.

http://codereview.chromium.org/3120006/diff/16001/17008#newcode2470
src/heap.cc:2470: // Special handling if the function and sharedfunctioninfo
objects
On 2010/08/11 07:50:03, Kasper Lund wrote:
> sharedfunctioninfo => shared info

Done.

http://codereview.chromium.org/3120006/diff/16001/17008#newcode2474
src/heap.cc:2474: // we flush the function if posible.
On 2010/08/11 07:50:03, Kasper Lund wrote:
> posible => possible.

Done.

http://codereview.chromium.org/3120006/diff/16001/17008#newcode2501
src/heap.cc:2501: // Check stack and archived threads for the code
On 2010/08/11 07:50:03, Kasper Lund wrote:
> Terminate comment with .

Done.

http://codereview.chromium.org/3120006/diff/16001/17008#newcode2520
src/heap.cc:2520: JSFunction* jsfunction = JSFunction::cast(obj);
On 2010/08/11 07:50:03, Kasper Lund wrote:
> jsfunction => function

Done.