Issue 3119042: Disable page_cycler_database on Mac. It looks like the perf bots are...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3119042: Disable page_cycler_database on Mac. It looks like the perf bots are... (Closed)

Created:
10 years, 4 months ago by dumi

Modified:
9 years, 7 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disable page_cycler_database on Mac. It looks like the perf bots are having some problems, and on Mac, those problems show up the most when running this test suite. TEST=none BUG=53140 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57265

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/test/page_cycler/page_cycler_test.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

LGTM Will you follow up on this next week?

10 years, 4 months ago (2010-08-24 23:22:03 UTC) #2

dumi

10 years, 4 months ago (2010-08-24 23:25:35 UTC) #3

On 2010/08/24 23:22:03, rohitrao wrote:
> LGTM
> 
> Will you follow up on this next week?

i'll try to... even though i've had only bad experiences with perf bots on win
and mac, so i'd rather let this test suite run only on the linux perf bot. then
i can actually track regressions instead of wasting X amount of time every
couple of months on fixing something unrelated.

Expand Messages | Collapse Messages