Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: chrome/browser/dom_ui/core_options_handler.h

Issue 3119038: yRevert 57093 - dom-ui options: record user metrics for pref changes.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/browser_options_handler.cc ('k') | chrome/browser/dom_ui/core_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/core_options_handler.h
===================================================================
--- chrome/browser/dom_ui/core_options_handler.h (revision 57095)
+++ chrome/browser/dom_ui/core_options_handler.h (working copy)
@@ -41,14 +41,8 @@
// Sets a pref value |value_string| of |pref_type| to given |pref_name|.
virtual void SetPref(const std::string& pref_name,
Value::ValueType pref_type,
- const std::string& value_string,
- const std::string& metric);
+ const std::string& value_string);
- // Records a user metric action for the given value.
- void ProcessUserMetric(Value::ValueType pref_type,
- const std::string& value_string,
- const std::string& metric);
-
typedef std::multimap<std::string, std::wstring> PreferenceCallbackMap;
PreferenceCallbackMap pref_callback_map_;
private:
@@ -77,10 +71,6 @@
void HandleSetPref(const ListValue* args, Value::ValueType type);
- // Callback for the "coreOptionsUserMetricsAction" message. This records
- // an action that should be tracked if metrics recording is enabled.
- void HandleUserMetricsAction(const ListValue* args);
-
void NotifyPrefChanged(const std::string* pref_name);
DISALLOW_COPY_AND_ASSIGN(CoreOptionsHandler);
« no previous file with comments | « chrome/browser/dom_ui/browser_options_handler.cc ('k') | chrome/browser/dom_ui/core_options_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698