Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3266)

Unified Diff: chrome/browser/resources/options/preferences.js

Issue 3119038: yRevert 57093 - dom-ui options: record user metrics for pref changes.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/pref_ui.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/preferences.js
===================================================================
--- chrome/browser/resources/options/preferences.js (revision 57095)
+++ chrome/browser/resources/options/preferences.js (working copy)
@@ -41,12 +41,9 @@
* and signals its changed value.
* @param {string} name Preference name.
* @param {boolean} value New preference value.
- * @param {string} metric User metrics identifier.
*/
- Preferences.setBooleanPref = function (name, value, metric) {
- var arguments = [name, value ? 'true' : 'false'];
- if (metric != undefined) arguments.push(metric);
- chrome.send('setBooleanPref', arguments);
+ Preferences.setBooleanPref = function (name, value) {
+ chrome.send('setBooleanPref', [name, value ? 'true' : 'false']);
};
/**
@@ -54,12 +51,9 @@
* and signals its changed value.
* @param {string} name Preference name.
* @param {number} value New preference value.
- * @param {string} metric User metrics identifier.
*/
- Preferences.setIntegerPref = function(name, value, metric) {
- var arguments = [name, String(value)];
- if (metric != undefined) arguments.push(metric);
- chrome.send('setIntegerPref', arguments);
+ Preferences.setIntegerPref = function(name, value) {
+ chrome.send('setIntegerPref', [name, String(value)]);
};
/**
@@ -67,12 +61,9 @@
* and signals its changed value.
* @param {string} name Preference name.
* @param {string} value New preference value.
- * @param {string} metric User metrics identifier.
*/
- Preferences.setStringPref = function(name, value, metric) {
- var arguments = [name, value];
- if (metric != undefined) arguments.push(metric);
- chrome.send('setStringPref', arguments);
+ Preferences.setStringPref = function(name, value) {
+ chrome.send('setStringPref', [name, value]);
};
/**
@@ -80,12 +71,9 @@
* and signals its changed value.
* @param {string} name Preference name.
* @param {string} value New preference value.
- * @param {string} metric User metrics identifier.
*/
- Preferences.setObjectPref = function(name, value, metric) {
- var arguments = [name, JSON.stringify(value)];
- if (metric != undefined) arguments.push(metric);
- chrome.send('setObjectPref', arguments);
+ Preferences.setObjectPref = function(name, value) {
+ chrome.send('setObjectPref', [name, JSON.stringify(value)]);
};
Preferences.prototype = {
« no previous file with comments | « chrome/browser/resources/options/pref_ui.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698