Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: chrome/browser/resources/options/pref_ui.js

Issue 3119038: yRevert 57093 - dom-ui options: record user metrics for pref changes.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/pref_ui.js
===================================================================
--- chrome/browser/resources/options/pref_ui.js (revision 57095)
+++ chrome/browser/resources/options/pref_ui.js (working copy)
@@ -33,7 +33,7 @@
// Listen to user events.
this.addEventListener('click',
function(e) {
- Preferences.setBooleanPref(self.pref, self.checked, self.metric);
+ Preferences.setBooleanPref(self.pref, self.checked);
});
}
};
@@ -44,12 +44,6 @@
*/
cr.defineProperty(PrefCheckbox, 'pref', cr.PropertyKind.ATTR);
- /**
- * The user metric string.
- * @type {string}
- */
- cr.defineProperty(PrefCheckbox, 'metric', cr.PropertyKind.ATTR);
-
/////////////////////////////////////////////////////////////////////////////
// PrefRadio class:
@@ -80,10 +74,10 @@
function(e) {
if(self.value == 'true' || self.value == 'false') {
Preferences.setBooleanPref(self.pref,
- self.value == 'true', self.metric);
+ self.value == 'true');
} else {
Preferences.setIntegerPref(self.pref,
- parseInt(self.value, 10), self.metric);
+ parseInt(self.value, 10));
}
});
},
@@ -103,11 +97,6 @@
}
};
- /**
- * The user metric string.
- * @type {string}
- */
- cr.defineProperty(PrefRadio, 'metric', cr.PropertyKind.ATTR);
/////////////////////////////////////////////////////////////////////////////
// PrefNumeric class:
@@ -135,7 +124,7 @@
// Listen to user events.
this.addEventListener('change',
function(e) {
- Preferences.setIntegerPref(self.pref, self.value, self.metric);
+ Preferences.setIntegerPref(self.pref, self.value);
});
}
};
@@ -146,12 +135,6 @@
*/
cr.defineProperty(PrefNumeric, 'pref', cr.PropertyKind.ATTR);
- /**
- * The user metric string.
- * @type {string}
- */
- cr.defineProperty(PrefNumeric, 'metric', cr.PropertyKind.ATTR);
-
/////////////////////////////////////////////////////////////////////////////
// PrefNumber class:
@@ -226,15 +209,15 @@
switch(self.dataType) {
case 'number':
Preferences.setIntegerPref(self.pref,
- self.options[self.selectedIndex].value, self.metric);
+ self.options[self.selectedIndex].value);
break;
case 'boolean':
Preferences.setBooleanValue(self.pref,
- self.options[self.selectedIndex].value, self.metric);
+ self.options[self.selectedIndex].value);
break;
case 'string':
Preferences.setStringPref(self.pref,
- self.options[self.selectedIndex].value, self.metric);
+ self.options[self.selectedIndex].value);
break;
}
});
@@ -272,12 +255,6 @@
*/
cr.defineProperty(PrefSelect, 'pref', cr.PropertyKind.ATTR);
- /**
- * The user metric string.
- * @type {string}
- */
- cr.defineProperty(PrefSelect, 'metric', cr.PropertyKind.ATTR);
-
/////////////////////////////////////////////////////////////////////////////
// PrefTextField class:
@@ -305,7 +282,7 @@
// Listen to user events.
this.addEventListener('change',
function(e) {
- Preferences.setStringPref(self.pref, self.value, self.metric);
+ Preferences.setStringPref(self.pref, self.value);
});
window.addEventListener('unload',
@@ -322,12 +299,6 @@
*/
cr.defineProperty(PrefTextField, 'pref', cr.PropertyKind.ATTR);
- /**
- * The user metric string.
- * @type {string}
- */
- cr.defineProperty(PrefTextField, 'metric', cr.PropertyKind.ATTR);
-
// Export
return {
PrefCheckbox: PrefCheckbox,
« no previous file with comments | « chrome/browser/resources/options/personal_options.js ('k') | chrome/browser/resources/options/preferences.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698