Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1373)

Unified Diff: src/trusted/plugin/ppapi/browser_interface_ppapi.h

Issue 3119028: Use console.log to report NaCl errors in Chrome instead of alerts (Closed) Base URL: http://nativeclient.googlecode.com/svn/trunk/src/native_client/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/plugin/ppapi/browser_interface_ppapi.h
===================================================================
--- src/trusted/plugin/ppapi/browser_interface_ppapi.h (revision 3042)
+++ src/trusted/plugin/ppapi/browser_interface_ppapi.h (working copy)
@@ -42,9 +42,13 @@
const nacl::string& text);
// Evaluate a JavaScript string in the browser.
- virtual bool EvalString(InstanceIdentifier plugin_identifier,
+ virtual bool EvalString(InstanceIdentifier instance_id,
const nacl::string& handler_string);
+ // Write to the JavaScript console.
+ virtual bool AddToConsole(InstanceIdentifier instance_id,
+ const nacl::string& text);
+
// Gets the full URL of the current page.
virtual bool GetFullURL(InstanceIdentifier instance_id,
nacl::string* full_url);

Powered by Google App Engine
This is Rietveld 408576698