Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2402)

Unified Diff: src/trusted/plugin/browser_interface.h

Issue 3119028: Use console.log to report NaCl errors in Chrome instead of alerts (Closed) Base URL: http://nativeclient.googlecode.com/svn/trunk/src/native_client/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/plugin/browser_interface.h
===================================================================
--- src/trusted/plugin/browser_interface.h (revision 3042)
+++ src/trusted/plugin/browser_interface.h (working copy)
@@ -49,13 +49,18 @@
const nacl::string& text) = 0;
// Evaluate a JavaScript string in the browser.
- virtual bool EvalString(InstanceIdentifier plugin_identifier,
+ virtual bool EvalString(InstanceIdentifier instance_id,
const nacl::string& str) = 0;
// Gets the full URL of the current page.
virtual bool GetFullURL(InstanceIdentifier instance_id,
nacl::string* full_url) = 0;
+ // Write to the JavaScript console. Currently works in Chrome only, generates
+ // an alert in other browsers.
+ virtual bool AddToConsole(InstanceIdentifier instance_id,
+ const nacl::string& text) = 0;
+
// Gets the origin of the current page. Origin is scheme://domain.
bool GetOrigin(InstanceIdentifier instance_id,
nacl::string* origin);
« no previous file with comments | « no previous file | src/trusted/plugin/npapi/browser_impl_npapi.h » ('j') | src/trusted/plugin/npapi/browser_impl_npapi.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698