Use console.log to report NaCl errors in Chrome instead of alerts

src/trusted/plugin/ppapi/browser_interface_ppapi.cc

 /*
  * Copyright 2010 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can
  * be found in the LICENSE file.
  */
 
 #include <assert.h>
 
 #include "native_client/src/trusted/plugin/ppapi/browser_interface_ppapi.h"
 
 #include "native_client/src/include/checked_cast.h"
 #include "native_client/src/include/nacl_elf.h"
 #include "native_client/src/include/nacl_macros.h"
 #include "native_client/src/include/portability.h"
 #include "native_client/src/trusted/plugin/api_defines.h"
 #include "native_client/src/trusted/plugin/ppapi/scriptable_handle_ppapi.h"
 #include "native_client/src/trusted/plugin/ppapi/var_utils.h"
 
 #include "ppapi/cpp/instance.h"
 #include "ppapi/cpp/var.h"
 
 using nacl::assert_cast;
 
 namespace {
 
+// TODO(polina): this function should return pp::Var
 bool GetWindow(plugin::InstanceIdentifier instance_id, pp::Var* window) {
   pp::Instance* instance = plugin::InstanceIdentifierToPPInstance(instance_id);
   *window = instance->GetWindowObject();
   return !window->is_void();
 }
 
 }  // namespace
 
 namespace plugin {
 
@@ skipping 20 matching lines @@
                                   const nacl::string& text) {
   pp::Var window;
   if (!GetWindow(instance_id, &window)) {
     return false;
   }
   pp::Var exception;
   window.Call("alert", text, &exception);
   return exception.is_void();
 }
 
+bool BrowserInterfacePpapi::AddToConsole(InstanceIdentifier instance_id,
+                                         const nacl::string& text) {
+  pp::Var window;
+  if (!GetWindow(instance_id, &window)) {
+    return false;
+  }
+  pp::Var exception;
+  window.GetProperty("console", &exception).Call("log", text, &exception);
+  return exception.is_void();
+}
 
 bool BrowserInterfacePpapi::EvalString(InstanceIdentifier instance_id,
                                        const nacl::string& expression) {
   pp::Var window;
   if (!GetWindow(instance_id, &window)) {
     return false;
   }
   pp::Var exception;
   window.Call("eval", expression, &exception);
   return exception.is_void();
@@ skipping 34 matching lines @@
 pp::Instance* InstanceIdentifierToPPInstance(InstanceIdentifier instance_id) {
   return reinterpret_cast<pp::Instance*>(assert_cast<intptr_t>(instance_id));
 }
 
 
 InstanceIdentifier PPInstanceToInstanceIdentifier(pp::Instance* instance) {
   return assert_cast<InstanceIdentifier>(reinterpret_cast<intptr_t>(instance));
 }
 
 }  // namespace plugin