Adds HostResolveImpl Requests and Jobs to log.

Adds HostResolveImpl Requests and Jobs to log.

Differences over the reverted version (http://codereview.chromium.org/3080034/show - reverted http://codereview.chromium.org/3137022/show ):
  * Jobs never log anything in their destructor, as the HostResolverImpl randomly outlives the NetLog, at least in some unit tests.
  * Removed the extra log entries for when a DNS lookup starts/completes.  Instead, the job's event is ended in OnLookupComplete().
  * Slight modification of the CanceledAsynchronousLookup unit test, as the Job is now closed before posting any events to the Request.  For actual lookups, this behavior means the Job's duration more accurately reflects the time the DNS lookup takes itself.


BUG=46844
TEST=Look at the net-internals screen.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57189

[mmenke, 2010-08-20 22:19:05]

Oops...Meant to publish it after sending it to the trybots.

[eroman, 2010-08-23 19:01:47]

LGTM

http://codereview.chromium.org/3119027/diff/42001/43011
File net/base/host_resolver_impl.cc (right):

http://codereview.chromium.org/3119027/diff/42001/43011#newcode140
net/base/host_resolver_impl.cc:140: dict->SetString("host",
StringPrintf("%s:%i",
This will not display IPv6 literals properly (as they need to be wrapped in
brackets before appending ":port".).

Ideally RequestInfo should be using a HostPortPair (and that is an open TODO).

For now I suggest doing this:

dict->SetString("host", HostPortPair(info_.hostname(),
info_.port()).ToString());

http://codereview.chromium.org/3119027/diff/42001/43011#newcode145
net/base/host_resolver_impl.cc:145: dict->SetInteger("allow_cached_response",
info_.allow_cached_response());
Use SetBoolean().

http://codereview.chromium.org/3119027/diff/42001/43011#newcode146
net/base/host_resolver_impl.cc:146: dict->SetInteger("is_speculative",
info_.is_speculative());
SetBoolean()

http://codereview.chromium.org/3119027/diff/42001/43012
File net/base/host_resolver_impl.h (right):

http://codereview.chromium.org/3119027/diff/42001/43012#newcode81
net/base/host_resolver_impl.h:81: NetLog* net_log_);
can you mention in the documentation here that |net_log| must remain valid for
the duration of HostResolverImpl's lifetime?

http://codereview.chromium.org/3119027/diff/42001/43016
File net/base/net_log.h (right):

http://codereview.chromium.org/3119027/diff/42001/43016#newcode74
net/base/net_log.h:74: Value* ToValue() const;
nit: could you mention here that owner is responsible for deleting the return
value?