Issue 3119026: Fix two-phase lookup problem in FlexibleBodyVisitor and FixedBodyVisitor....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3119026: Fix two-phase lookup problem in FlexibleBodyVisitor and FixedBodyVisitor.... (Closed)

Created:
10 years, 4 months ago by hans

Modified:
9 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix two-phase lookup problem in FlexibleBodyVisitor and FixedBodyVisitor. In FlexibleBodyVisitor and FixedBodyVisitor, the calls to IteratePointers, which lives in the base class BodyVisitorBase<StaticVisitor>, needs to be qualified with the dependent base class to be able to be bound during two-phase lookup. Committed: http://code.google.com/p/v8/source/detail?r=5303

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	src/objects-visiting.h	View		2 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hans

I'm helping out with building Chrome using Clang and this broke the build when we ...

10 years, 4 months ago (2010-08-18 15:05:30 UTC) #1

Vyacheslav Egorov (Chromium)

10 years, 4 months ago (2010-08-18 15:26:02 UTC) #3

Landed in r5303. Closing issue. Thanks for patch!

Expand Messages | Collapse Messages