Various improvements to oom_dump and instance type lists.

Various improvements to oom_dump and instance type lists.

1) addresses various Mark's concern;
2) adds some missing instance types and rearranges existing ones to follow
  InstanceType order;
3) various minor cleanups.

Committed: http://code.google.com/p/v8/source/detail?r=5286

[antonm, 2010-08-17 13:13:47]

Mads and Mark,

may you have a look?

[Mark Mentovai, 2010-08-17 13:21:21]

LGTM. Much better, thanks!

http://codereview.chromium.org/3119023/diff/1/5
File tools/oom_dump/README (right):

http://codereview.chromium.org/3119023/diff/1/5#newcode26
tools/oom_dump/README:26: (Additionally you can control v8 working copy dir, but
default should work.)
“but the default”

http://codereview.chromium.org/3119023/diff/1/5#newcode29
tools/oom_dump/README:29: some useful information about the OOM crash.
Maybe the README should mention that this is limited to processing x86 dumps for
the time being.

http://codereview.chromium.org/3119023/diff/1/6
File tools/oom_dump/oom_dump.cc (right):

http://codereview.chromium.org/3119023/diff/1/6#newcode131
tools/oom_dump/oom_dump.cc:131: // Currently only Windows 32-bits minidumps are
supported.
32-bit (singular, no s).

I apologize for English. :(

[antonm, 2010-08-17 13:25:05]

Thank you very much for review, Mark.

http://codereview.chromium.org/3119023/diff/1/5
File tools/oom_dump/README (right):

http://codereview.chromium.org/3119023/diff/1/5#newcode26
tools/oom_dump/README:26: (Additionally you can control v8 working copy dir, but
default should work.)
On 2010/08/17 13:21:21, Mark Mentovai wrote:
> “but the default”

Done.

http://codereview.chromium.org/3119023/diff/1/5#newcode29
tools/oom_dump/README:29: some useful information about the OOM crash.
On 2010/08/17 13:21:21, Mark Mentovai wrote:
> Maybe the README should mention that this is limited to processing x86 dumps
for
> the time being.

Done.

http://codereview.chromium.org/3119023/diff/1/6
File tools/oom_dump/oom_dump.cc (right):

http://codereview.chromium.org/3119023/diff/1/6#newcode131
tools/oom_dump/oom_dump.cc:131: // Currently only Windows 32-bits minidumps are
supported.
On 2010/08/17 13:21:21, Mark Mentovai wrote:
> 32-bit (singular, no s).
> 
> I apologize for English. :(

Done.  It me who should apologize for English :)

[Mark Mentovai, 2010-08-17 13:28:55]

LGTM

[Mads Ager (chromium), 2010-08-17 13:30:56]

LGTM too.