Header cleanup in base....

Header cleanup in base.

This makes uses of StringPrintf and friends use the base namespace and include
stringprintf.h explicitly. This also removes a bunch of unnecessary string_util
includes (which exposed a few other errors like people forgetting to include
<vector>.

TEST=it compiles
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56446

[viettrungluu, 2010-08-17 05:09:15]

LGTM with a couple more fixes, if it builds.

(Maybe you should grep for '[^:]StringPrintf' etc.?)

http://codereview.chromium.org/3119022/diff/1/11
File base/logging.cc (right):

http://codereview.chromium.org/3119022/diff/1/11#newcode1
base/logging.cc:1: // Copyright (c) 2006-2009 The Chromium Authors. All rights
reserved.
2010 ;)

http://codereview.chromium.org/3119022/diff/1/15
File base/process_util_posix.cc (right):

http://codereview.chromium.org/3119022/diff/1/15#newcode297
base/process_util_posix.cc:297: return StringPrintf("0x%x %s", err,
mach_error_string(err));
base::?

http://codereview.chromium.org/3119022/diff/1/15#newcode308
base/process_util_posix.cc:308: std::string mach_connection_name = StringPrintf(
"

http://codereview.chromium.org/3119022/diff/1/28
File base/tracked.cc (right):

http://codereview.chromium.org/3119022/diff/1/28#newcode31
base/tracked.cc:31: StringAppendF(output, "%s[%d] ",
base::?

[brettw, 2010-08-17 05:26:30]

On Mon, Aug 16, 2010 at 10:09 PM,  <viettrungluu@chromium.org> wrote:
> LGTM with a couple more fixes, if it builds.
>
> (Maybe you should grep for '[^:]StringPrintf' etc.?)

This doesn't work since many of the files in base (like
process_util_posix that you mentioned) use the base namespace
themselves, and I wasn't adding "base::" to those. Thanks for catching
the one in tracked.cc