Issue 3119005: ARM: Remove some spill scopes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3119005: ARM: Remove some spill scopes (Closed)

Created:
10 years, 4 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Remove some spill scopes Committed: http://code.google.com/p/v8/source/detail?r=5238

Patch Set 4 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -55 lines)			Patch
	M	src/arm/codegen-arm.cc	View	1 2 3	9 chunks	+46 lines, -55 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/3119005/diff/7001/8001 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/3119005/diff/7001/8001#newcode4693 src/arm/codegen-arm.cc:4693: Register result = r6; Please add a comment ...

10 years, 4 months ago (2010-08-11 10:43:51 UTC) #2

Søren Thygesen Gjesse

10 years, 4 months ago (2010-08-11 10:55:02 UTC) #3

http://codereview.chromium.org/3119005/diff/7001/8001
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/3119005/diff/7001/8001#newcode4693
src/arm/codegen-arm.cc:4693: Register result = r6;
On 2010/08/11 10:43:51, Erik Corry wrote:
> Please add a comment that this register is used without notifying the virtual
> frame (OK at the moment because the virtual frame doesn't use r6 yet).

Done.

http://codereview.chromium.org/3119005/diff/7001/8001#newcode5129
src/arm/codegen-arm.cc:5129: Register result = r0;  // Free as frame jas just
been spilled.
On 2010/08/11 10:43:51, Erik Corry wrote:
> jas -> has

Done.

Expand Messages | Collapse Messages

Issue 3119005: ARM: Remove some spill scopes (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages