Issue 3119: When a bitmap allocation fails, do some checks that will crash in different...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3119: When a bitmap allocation fails, do some checks that will crash in different... (Closed)

Created:
12 years, 3 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

When a bitmap allocation fails, do some checks that will crash in different ways so we can get a better picture when looking at the crash reports of why the allocation might be failing. BUG=1275638 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2548

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -1 line)			Patch
	M	base/gfx/bitmap_platform_device_win.cc	View		3 chunks	+29 lines, -1 line	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mike Belshe

12 years, 3 months ago (2008-09-24 00:41:41 UTC) #2

lgtm

http://codereview.chromium.org/3119/diff/1/2
File base/gfx/bitmap_platform_device_win.cc (right):

http://codereview.chromium.org/3119/diff/1/2#newcode105
Line 105: // failure. It takes
Incomplete sentence?  "It takes"

http://codereview.chromium.org/3119/diff/1/2#newcode119
Line 119: const int64 kLotsOfMem = 1500000000;  // 1.5GB.
This is arbitrary, but I would have tripped this for anything over 1GB.  1.5GB
is ok too.

Expand Messages | Collapse Messages