Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 3118014: Update TPM initialization to better handle errors. (Closed)

Created:
10 years, 4 months ago by fes
Modified:
9 years, 7 months ago
Reviewers:
rginda
CC:
chromium-os-reviews_chromium.org
Base URL:
http://src.chromium.org/git/tpm_init.git
Visibility:
Public.

Description

Update TPM initialization to better handle errors. This change modifies slightly the TPM initialization, changing it to use a well-known owner password until the last step, when it changes the owner password to a random string. This way, if ownership is interrupted, it has a better chance of being able to resume or being diagnosed. This change allows use of the TPM emulator by adding detection of whether or not the emulator is owned, as well as checking if the SRK needs the owner password before trying to unrestrict it (the unrestrict code path fails on the TPM emulator but not on hardware TPMs--I do not know why, but the tpm_restrictsrk utility also does not work on the emulator). Change-Id: I4957205bb72b6d1a5009ca3372db6aefd58db3d9 BUG=5561 TEST=manual

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -92 lines) Patch
M tpm.h View 6 chunks +29 lines, -10 lines 0 comments Download
M tpm.cc View 15 chunks +161 lines, -82 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fes
10 years, 4 months ago (2010-08-12 23:21:00 UTC) #1
rginda
10 years, 4 months ago (2010-08-13 01:03:03 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698