Issue 3118013: Add last OS error into heap stats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3118013: Add last OS error into heap stats. (Closed)

Created:
10 years, 4 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Søren Thygesen Gjesse, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Add last OS error into heap stats. That could allow us to understand why commit of from space sometimes fails. Another option would be start a separate structure with OS-related info, but as it's a single field, let's put it into HeapStats, at least for now. Committed: http://code.google.com/p/v8/source/detail?r=5261

Patch Set 1 #

Patch Set 2 : rename errno to os_error #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -1 line)			Patch
M	src/api.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/heap.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/heap.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/platform.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/platform-nullos.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/platform-posix.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/platform-win32.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

antonm

Mads, Søren, may you have a look? I am going to try to bring it ...

10 years, 4 months ago (2010-08-12 19:42:39 UTC) #1

Mads Ager (chromium)

LGTM I see no problem with merging this to the 2.2 branch as well.

10 years, 4 months ago (2010-08-13 06:24:07 UTC) #2

antonm

10 years, 4 months ago (2010-08-13 11:11:22 UTC) #4

Thanks a lot for review.

I had to rename errno to os_error as otherwise VS2005 failed to build it, hope
it's fine with you.

Expand Messages | Collapse Messages