Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: src/heap-profiler.cc

Issue 3118007: Heap profiler: enforce compaction before taking a snapshot. (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 342 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 } 353 }
354 354
355 355
356 HeapSnapshot* HeapProfiler::TakeSnapshot(String* name) { 356 HeapSnapshot* HeapProfiler::TakeSnapshot(String* name) {
357 ASSERT(singleton_ != NULL); 357 ASSERT(singleton_ != NULL);
358 return singleton_->TakeSnapshotImpl(name); 358 return singleton_->TakeSnapshotImpl(name);
359 } 359 }
360 360
361 361
362 HeapSnapshot* HeapProfiler::TakeSnapshotImpl(const char* name) { 362 HeapSnapshot* HeapProfiler::TakeSnapshotImpl(const char* name) {
363 Heap::CollectAllGarbage(false); 363 Heap::CollectAllGarbage(true);
364 HeapSnapshot* result = snapshots_->NewSnapshot(name, next_snapshot_uid_++); 364 HeapSnapshot* result = snapshots_->NewSnapshot(name, next_snapshot_uid_++);
365 HeapSnapshotGenerator generator(result); 365 HeapSnapshotGenerator generator(result);
366 generator.GenerateSnapshot(); 366 generator.GenerateSnapshot();
367 snapshots_->SnapshotGenerationFinished(); 367 snapshots_->SnapshotGenerationFinished();
368 return result; 368 return result;
369 } 369 }
370 370
371 371
372 HeapSnapshot* HeapProfiler::TakeSnapshotImpl(String* name) { 372 HeapSnapshot* HeapProfiler::TakeSnapshotImpl(String* name) {
373 return TakeSnapshotImpl(snapshots_->GetName(name)); 373 return TakeSnapshotImpl(snapshots_->GetName(name));
(...skipping 396 matching lines...) Expand 10 before | Expand all | Expand 10 after
770 GlobalHandles::MakeWeak(handle.location(), 770 GlobalHandles::MakeWeak(handle.location(),
771 static_cast<void*>(stack.start()), 771 static_cast<void*>(stack.start()),
772 StackWeakReferenceCallback); 772 StackWeakReferenceCallback);
773 } 773 }
774 774
775 775
776 #endif // ENABLE_LOGGING_AND_PROFILING 776 #endif // ENABLE_LOGGING_AND_PROFILING
777 777
778 778
779 } } // namespace v8::internal 779 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698