Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2883)

Unified Diff: chrome/browser/task_manager_resource_providers.h

Issue 3118003: Revert 55449 - Fix some problems with TaskManagerBrowserTest.PopulateWebCache... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/task_manager_browsertest.cc ('k') | chrome/browser/task_manager_resource_providers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager_resource_providers.h
===================================================================
--- chrome/browser/task_manager_resource_providers.h (revision 55529)
+++ chrome/browser/task_manager_resource_providers.h (working copy)
@@ -35,7 +35,7 @@
base::ProcessHandle GetProcess() const;
TabContents* GetTabContents() const;
- virtual bool HasCacheStats() const { return had_stats_update_; }
+ virtual bool ReportsCacheStats() const { return true; }
virtual WebKit::WebCache::ResourceTypeStats GetWebCoreCacheStats() const;
virtual bool ReportsV8MemoryStats() const { return true; }
@@ -58,18 +58,12 @@
TabContents* tab_contents_;
base::ProcessHandle process_;
int pid_;
-
// The stats_ field holds information about resource usage in the renderer
// process and so it is updated asynchronously by the Refresh() call.
WebKit::WebCache::ResourceTypeStats stats_;
-
// This flag is true if we are waiting for the renderer to report its stats.
bool pending_stats_update_;
- // This flag is true after we received at least one stats report
- // from the renderer.
- bool had_stats_update_;
-
// We do a similar dance to gather the V8 memory usage in a process.
size_t v8_memory_allocated_;
size_t v8_memory_used_;
« no previous file with comments | « chrome/browser/task_manager_browsertest.cc ('k') | chrome/browser/task_manager_resource_providers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698