Issue 3118003: Revert 55449 - Fix some problems with TaskManagerBrowserTest.PopulateWebCache...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3118003: Revert 55449 - Fix some problems with TaskManagerBrowserTest.PopulateWebCache... (Closed)

Created:
10 years, 4 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 55449 - Fix some problems with TaskManagerBrowserTest.PopulateWebCacheFields: - wait for an actual update to occur; otherwise we're not testing the real thing - change DCHECKs to EXPECT_EQs; that's what we should use in tests This change should also fix the crashiness of this test. TEST=browser_tests BUG=42301 Review URL: http://codereview.chromium.org/2856091 TBR=phajdan.jr@chromium.org,glen@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55530

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -40 lines)			Patch
M	chrome/browser/task_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/task_manager.cc	View	6 chunks	+5 lines, -10 lines	0 comments	Download
M	chrome/browser/task_manager_browsertest.cc	View	3 chunks	+6 lines, -13 lines	0 comments	Download
M	chrome/browser/task_manager_resource_providers.h	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	chrome/browser/task_manager_resource_providers.cc	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/common/notification_type.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

OK

Apparently it's not so easy to fix.