Issue 3117044: Add --disable-translate to help Selenium/WebDriver dudes make Chrome...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3117044: Add --disable-translate to help Selenium/WebDriver dudes make Chrome... (Closed)

Created:
10 years, 4 months ago by John Grabowski

Modified:
9 years, 6 months ago

Reviewers:
Jay Civelli, jcampan

CC:
chromium-reviews, ben+cc_chromium.org, kevin_mogotest.com, shs_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add --disable-translate to help Selenium/WebDriver dudes make Chrome more predictable for automated testing. BUG=none TEST=Launch Chrome. Go to http://www.diplomatie.gouv.fr/fr/ See translate info bar? Good. Now launch Chrome with --disable-translate and go to that page again. Make sure translate info bar never shows up. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57620

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -0 lines)			Patch
M	chrome/browser/translate/translate_manager.cc	View	3 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

This won't make it into Chrome6 but will probably be seen in early Dev Channel ...

10 years, 4 months ago (2010-08-26 20:10:42 UTC) #1

LGTM

Expand Messages | Collapse Messages