Issue 3117035: Mac: Unregress right-clicks for CoreAnimation plugins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3117035: Mac: Unregress right-clicks for CoreAnimation plugins. (Closed)

Created:
10 years, 4 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews, John Grabowski, ben+cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org

Visibility:
Public.

Description

Mac: Unregress right-clicks for CoreAnimation plugins. BUG=52593, 51748 TEST=Right-click a youtube video. Should get context menu. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57058

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	chrome/browser/renderer_host/render_widget_host_view_mac.mm	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

I searched NSResponder's docs for "Note", and rightMouseDown seems to be the only method that's ...

10 years, 4 months ago (2010-08-23 14:35:22 UTC) #1

stuartmorgan

LGTM with nit http://codereview.chromium.org/3117035/diff/1/2 File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right): http://codereview.chromium.org/3117035/diff/1/2#newcode246 chrome/browser/renderer_host/render_widget_host_view_mac.mm:246: if ([self nextResponder]) Since there's no ...

10 years, 4 months ago (2010-08-23 15:36:14 UTC) #2

Nico

10 years, 4 months ago (2010-08-23 15:38:06 UTC) #3

thanks!

http://codereview.chromium.org/3117035/diff/1/2
File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/3117035/diff/1/2#newcode246
chrome/browser/renderer_host/render_widget_host_view_mac.mm:246: if ([self
nextResponder])
On 2010/08/23 15:36:14, stuartmorgan wrote:
> Since there's no else, and messaging nil is safe, this check is unnecessary.

d'ohne

Expand Messages | Collapse Messages