Issue 3117034: Skeleton of sync handler on the I/O thread for GetSearchProviderInstallState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3117034: Skeleton of sync handler on the I/O thread for GetSearchProviderInstallState. (Closed)

Created:
10 years, 4 months ago by levin

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org

Visibility:
Public.

Description

Skeleton of sync handler on the I/O thread for GetSearchProviderInstallState. BUG=38475 TEST=Not fully testable yet (but the test is unit_test --gtest_filter=SearchProviderTest.TestIsSearchProviderInstalled Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57114

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+172 lines, -5 lines)			Patch
M	chrome/browser/renderer_host/resource_message_filter.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_message_filter.cc	View	3 chunks	+6 lines, -0 lines	0 comments	Download
A	chrome/browser/search_engines/search_provider_install_state_dispatcher_host.h	View	1 chunk	+55 lines, -0 lines	1 comment	Download
A	chrome/browser/search_engines/search_provider_install_state_dispatcher_host.cc	View	1 chunk	+90 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/renderer/external_extension.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/renderer/render_view.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

10 years, 4 months ago (2010-08-23 16:00:29 UTC) #2

LGTM

http://codereview.chromium.org/3117034/diff/1/5
File
chrome/browser/search_engines/search_provider_install_state_dispatcher_host.h
(right):

http://codereview.chromium.org/3117034/diff/1/5#newcode22
chrome/browser/search_engines/search_provider_install_state_dispatcher_host.h:22:
SearchProviderInstallStateDispatcherHost(ResourceMessageFilter* ipc_sender,
Mention this is invoked on the UI thread.

Expand Messages | Collapse Messages