Fix for the ChromeFrame unload event test failures seen on the builder. For s...

Fix for the ChromeFrame unload event test failures seen on the builder. For some reason
the test shows up as succeeded even though it is failing.

The test fails when the automation client instance is reused, i.e the new page loads in
the same tab. We need to set the ready state of the active document instance to ready
when we reuse the automation client instance.

TBR=amit


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56963

[amit, 2010-08-21 17:38:26]

ok. Thanks for debugging.

On Fri, Aug 20, 2010 at 6:18 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Fix for the ChromeFrame unload event test failures seen on the builder. For
> some
> reason
> the test shows up as succeeded even though it is failing.
>
> The test fails when the automation client instance is reused, i.e the new
> page
> loads in
> the same tab. We need to set the ready state of the active document
> instance to
> ready
> when we reuse the automation client instance.
>
> TBR=amit
>
>
> Please review this at http://codereview.chromium.org/3117032/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/chrome_active_document.cc
>
>
> Index: chrome_frame/chrome_active_document.cc
> ===================================================================
> --- chrome_frame/chrome_active_document.cc      (revision 56679)
> +++ chrome_frame/chrome_active_document.cc      (working copy)
> @@ -83,6 +83,7 @@
>     DCHECK(automation_client_.get() != NULL);
>     automation_client_->Reinitialize(this, url_fetcher_.get());
>     is_automation_client_reused_ = true;
> +    OnAutomationServerReady();
>   } else {
>     // The FinalConstruct implementation in the ChromeFrameActivexBase
> class
>     // i.e. Base creates an instance of the ChromeFrameAutomationClient
> class
>
>
>