Adds ui_test_utils::SendAndWaitForKeyPress and converts callers (where

chrome/test/ui_test_utils.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/ui_test_utils.h"
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/json/json_reader.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
 #include "base/process_util.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
+#include "chrome/browser/automation/ui_controls.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/dom_operation_notification_details.h"
 #include "chrome/browser/download/download_item.h"
 #include "chrome/browser/download/download_manager.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/renderer_host/render_process_host.h"
 #include "chrome/browser/renderer_host/render_view_host.h"
 #include "chrome/browser/tab_contents/navigation_controller.h"
 #include "chrome/browser/tab_contents/navigation_entry.h"
@@ skipping 515 matching lines @@
 void WaitForBookmarkModelToLoad(BookmarkModel* model) {
   if (model->IsLoaded())
     return;
   BookmarkLoadObserver observer;
   model->AddObserver(&observer);
   RunMessageLoop();
   model->RemoveObserver(&observer);
   ASSERT_TRUE(model->IsLoaded());
 }
 
+bool SendKeyPressSync(gfx::NativeWindow window,
+                      base::KeyboardCode key,
+                      bool control,
+                      bool shift,
+                      bool alt,
+                      bool command) {
+  if (!ui_controls::SendKeyPressNotifyWhenDone(
+          window, key, control, shift, alt, command,
+          new MessageLoop::QuitTask())) {
+    DLOG(ERROR) << "ui_controls::SendKeyPressNotifyWhenDone failed";

[Paweł Hajdan Jr., 2010/08/21 02:44:28]

nit: You can consider using LOG instead of DLOG here. We should rarely enter the
failure case. Up to you.

+    return false;
+  }
+  // Run the message loop, it'll quit because either the key was received or the

[Paweł Hajdan Jr., 2010/08/21 02:44:28]

nit: I think this comment is confusing. I'd rather remove it, but if you think
it should really be there, that's fine.

+  // test timed out.
+  RunMessageLoop();
+  return !testing::Test::HasFatalFailure();
+}
+
 TimedMessageLoopRunner::TimedMessageLoopRunner()
     : loop_(new MessageLoopForUI()),
       owned_(true),
       quit_loop_invoked_(false) {
 }
 
 TimedMessageLoopRunner::~TimedMessageLoopRunner() {
   if (owned_)
     delete loop_;
 }
@@ skipping 93 matching lines @@
 
 TestWebSocketServer::~TestWebSocketServer() {
   scoped_ptr<CommandLine> cmd_line(CreateWebSocketServerCommandLine());
   cmd_line->AppendSwitchASCII("server", "stop");
   cmd_line->AppendSwitch("chromium");
   cmd_line->AppendSwitchPath("pidfile", websocket_pid_file_);
   base::LaunchApp(*cmd_line.get(), true, false, NULL);
 }
 
 }  // namespace ui_test_utils