Issue 3117024: Clean up ExtensionMessageService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3117024: Clean up ExtensionMessageService. (Closed)

Created:
10 years, 4 months ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org

Visibility:
Public.

Description

Clean up ExtensionMessageService. - Remove debugging cruft from an old bug that has been closed. - Make it UI-thread only. This complicates ResourceMessageFilter a little, but makes the EMS lifetime a lot easier to reason about. BUG=no TEST=covered by unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56761

Patch Set 1 #

Patch Set 2 : comments fixed #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+131 lines, -262 lines)			Patch
M	chrome/browser/automation/extension_port_container.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/debugger/extension_ports_remote_service.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/extension_message_service.h	View	1	9 chunks	+35 lines, -69 lines	0 comments	Download
M	chrome/browser/extensions/extension_message_service.cc	View		23 chunks	+45 lines, -150 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_message_filter.h	View		3 chunks	+10 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_message_filter.cc	View		2 chunks	+41 lines, -14 lines	0 comments	Download
M	chrome/common/notification_type.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

nice, lgtm

Expand Messages | Collapse Messages