Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 3117007: Allow compiling with strict aliasing enabled on GCC 4.4. (Closed)

Created:
10 years, 4 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev, saurik_saurik.com
Visibility:
Public.

Description

Allow compiling with strict aliasing enabled on GCC 4.4. Patch by Jay Freeman. Fixes issue 463.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M SConstruct View 2 chunks +1 line, -2 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/simulator-mips.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/top.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/utils.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
10 years, 4 months ago (2010-08-11 10:10:37 UTC) #1
Mads Ager (chromium)
10 years, 4 months ago (2010-08-11 10:50:40 UTC) #2
LGTM

Thanks for fixing this Jay! :)

Powered by Google App Engine
This is Rietveld 408576698