src/runtime.js - Issue 3117006: Handle overwriting valueOf on String objects correctly when adding...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.js

Issue 3117006: Handle overwriting valueOf on String objects correctly when adding... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.js

===================================================================

--- src/runtime.js (revision 5232)

+++ src/runtime.js (working copy)

@@ -175,7 +175,7 @@

// Left operand (this) is already a string.

function STRING_ADD_LEFT(y) {

if (!IS_STRING(y)) {

- if (IS_STRING_WRAPPER(y)) {

+ if (IS_STRING_WRAPPER(y) && %_IsStringWrapperSafeForDefaultValueOf(y)) {

y = %_ValueOf(y);

} else {

y = IS_NUMBER(y)

@@ -191,7 +191,7 @@

function STRING_ADD_RIGHT(y) {

var x = this;

if (!IS_STRING(x)) {

- if (IS_STRING_WRAPPER(x)) {

+ if (IS_STRING_WRAPPER(x) && %_IsStringWrapperSafeForDefaultValueOf(x)) {

x = %_ValueOf(x);

} else {

x = IS_NUMBER(x)

« no previous file with comments | « src/objects.h ('k') | src/x64/codegen-x64.h » ('j') | no next file with comments »