Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: src/ia32/macro-assembler-ia32.cc

Issue 3117006: Handle overwriting valueOf on String objects correctly when adding... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 j(zero, &ok); 366 j(zero, &ok);
367 cmp(FieldOperand(object, HeapObject::kMapOffset), 367 cmp(FieldOperand(object, HeapObject::kMapOffset),
368 Factory::heap_number_map()); 368 Factory::heap_number_map());
369 Assert(equal, "Operand not a number"); 369 Assert(equal, "Operand not a number");
370 bind(&ok); 370 bind(&ok);
371 } 371 }
372 372
373 373
374 void MacroAssembler::AbortIfNotSmi(Register object) { 374 void MacroAssembler::AbortIfNotSmi(Register object) {
375 test(object, Immediate(kSmiTagMask)); 375 test(object, Immediate(kSmiTagMask));
376 Assert(equal, "Operand not a smi"); 376 Assert(equal, "Operand is not a smi");
377 } 377 }
378 378
379 379
380 void MacroAssembler::AbortIfSmi(Register object) { 380 void MacroAssembler::AbortIfSmi(Register object) {
381 test(object, Immediate(kSmiTagMask)); 381 test(object, Immediate(kSmiTagMask));
382 Assert(not_equal, "Operand a smi"); 382 Assert(not_equal, "Operand is a smi");
383 } 383 }
384 384
385 385
386 void MacroAssembler::EnterFrame(StackFrame::Type type) { 386 void MacroAssembler::EnterFrame(StackFrame::Type type) {
387 push(ebp); 387 push(ebp);
388 mov(ebp, Operand(esp)); 388 mov(ebp, Operand(esp));
389 push(esi); 389 push(esi);
390 push(Immediate(Smi::FromInt(type))); 390 push(Immediate(Smi::FromInt(type)));
391 push(Immediate(CodeObject())); 391 push(Immediate(CodeObject()));
392 if (FLAG_debug_code) { 392 if (FLAG_debug_code) {
(...skipping 1279 matching lines...) Expand 10 before | Expand all | Expand 10 after
1672 1672
1673 // Check that the code was patched as expected. 1673 // Check that the code was patched as expected.
1674 ASSERT(masm_.pc_ == address_ + size_); 1674 ASSERT(masm_.pc_ == address_ + size_);
1675 ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap); 1675 ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap);
1676 } 1676 }
1677 1677
1678 1678
1679 } } // namespace v8::internal 1679 } } // namespace v8::internal
1680 1680
1681 #endif // V8_TARGET_ARCH_IA32 1681 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698