Issue 3116035: add new 'factory_Verify' test which verifies all required tests are finished.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3116035: add new 'factory_Verify' test which verifies all required tests are finished. (Closed)

Created:
10 years, 4 months ago by Hung-Te

Modified:
9 years, 7 months ago

Reviewers:
Tammo Spalink, Nick Sanders

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/autotest.git

Visibility:
Public.

Description

add new 'factory_Verify' test which verifies all required tests are finished. suite_Factory/test_list must also use unique_name to specify corresponding test targets. That part will be included in another CL: http://codereview.chromium.org/3180022/show BUG=chrome-os-partner:827 TEST=manual Change-Id: Ide28d16dc8b2a8815e4eee7e0dbf920e429a3f6e

Patch Set 1 #

Total comments: 4

Patch Set 2 : indent/message refine as reviewer suggested #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -0 lines)			Patch
	A	client/site_tests/factory_Verify/factory_Verify.py	View	1	1 chunk	+102 lines, -0 lines	0 comments	Download
	A	client/site_tests/factory_Verify/force_run	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Tammo Spalink

lgtm, assuming nits are fixed http://codereview.chromium.org/3116035/diff/1/2 File client/site_tests/factory_Verify/factory_Verify.py (right): http://codereview.chromium.org/3116035/diff/1/2#newcode76 client/site_tests/factory_Verify/factory_Verify.py:76: raise error.TestFail('Some previous tests ...

10 years, 4 months ago (2010-08-25 03:13:35 UTC) #2

Hung-Te

10 years, 4 months ago (2010-08-25 03:51:10 UTC) #3

http://codereview.chromium.org/3116035/diff/1/2
File client/site_tests/factory_Verify/factory_Verify.py (right):

http://codereview.chromium.org/3116035/diff/1/2#newcode76
client/site_tests/factory_Verify/factory_Verify.py:76: raise
error.TestFail('Some previous tests were failed: %s' %
On 2010/08/25 03:13:35, Tammo Spalink wrote:
> /s were f/s f/

Done.

http://codereview.chromium.org/3116035/diff/1/3
File client/site_tests/factory_Verify/force_run (right):

http://codereview.chromium.org/3116035/diff/1/3#newcode18
client/site_tests/factory_Verify/force_run:18: check_required_tests=False,
On 2010/08/25 03:13:35, Tammo Spalink wrote:
> indent looks wrong here

Done.

Expand Messages | Collapse Messages