Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3116029: Fix cbuildbot. Mistakenly used str.open instead of open (Closed)

Created:
10 years, 4 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://git@chromiumos-git//crosutils.git
Visibility:
Public.

Description

Fix cbuildbot. Mistakenly used str.open instead of open TEST=Test underway.

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M bin/cbuildbot.py View 1 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sosa
10 years, 4 months ago (2010-08-20 17:33:50 UTC) #1
petkov
LGTM w/ a comment. http://codereview.chromium.org/3116029/diff/1/2 File bin/cbuildbot.py (right): http://codereview.chromium.org/3116029/diff/1/2#newcode116 bin/cbuildbot.py:116: print 'Could not open %s' ...
10 years, 4 months ago (2010-08-20 17:39:12 UTC) #2
sosa
10 years, 4 months ago (2010-08-20 17:55:30 UTC) #3 
Good point.  I clear-ified  the error message and cleared revisions on error. 
Pushing

http://codereview.chromium.org/3116029/diff/1/2
File bin/cbuildbot.py (right):

http://codereview.chromium.org/3116029/diff/1/2#newcode116
bin/cbuildbot.py:116: print 'Could not open %s' % revisionfile
On 2010/08/20 17:39:12, petkov wrote:
> Don't you want to print this to stderr too? And, intentionally masking the
> exception? Theoretically, you could get an exception on close too (I guess),
in
> which case you'd see the error message but revisions may not be set to None
any
> more.
> 

Done.

Powered by Google App Engine
This is Rietveld 408576698