Add Mac output for policy template generator

Add Mac output for policy template generator

Writer for plist manifest and string table files, and custom strings for the Mac templates.

BUG=49316
TEST=plist_writer_unittest.*, plist_strings_writer_unittest.* (grit)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57307

[gfeher, 2010-08-24 15:05:56]

Hi, please review this. Would you like me to ask someone else to check the user
messages?

[Jói, 2010-08-24 15:20:23]

Groovy.  Please add unit tests for the two new writers.

Cheers,
Jói

http://codereview.chromium.org/3116027/diff/16019/4002
File chrome/app/policy/policy_templates.grd (right):

http://codereview.chromium.org/3116027/diff/16019/4002#newcode331
chrome/app/policy/policy_templates.grd:331:
http://www.chromium.org/developers/design-documents/network-settings#TOC-Comm...
Should probably put a placeholder around this so translators don't try to
translate the URL

http://codereview.chromium.org/3116027/diff/16019/4002#newcode341
chrome/app/policy/policy_templates.grd:341:
http://www.chromium.org/developers/design-documents/network-settings#TOC-Comm...
ditto

http://codereview.chromium.org/3116027/diff/16019/4002#newcode349
chrome/app/policy/policy_templates.grd:349:
http://www.chromium.org/developers/design-documents/network-settings#TOC-Comm...
ditto

http://codereview.chromium.org/3116027/diff/16019/4002#newcode357
chrome/app/policy/policy_templates.grd:357:
http://www.chromium.org/developers/design-documents/network-settings#TOC-Comm...
ditto

http://codereview.chromium.org/3116027/diff/16019/4004
File tools/grit/grit/format/policy_templates/writers/plist_strings_writer.py
(right):

http://codereview.chromium.org/3116027/diff/16019/4004#newcode6
tools/grit/grit/format/policy_templates/writers/plist_strings_writer.py:6: from
template_writer import TemplateWriter
GRIT style (and Google style) is to import from the root of the project, and to
prefer to import namespaces only, so (since you're only using TemplateWriter
once) I would recommend

from grit.format.policy_templates.writers import template_writer

http://codereview.chromium.org/3116027/diff/16019/4004#newcode9
tools/grit/grit/format/policy_templates/writers/plist_strings_writer.py:9: def
GetWriter(info, messages):
Needs docstring; also it's unclear to me why you need it at all, rather than
just calling the constructor.  I thought it might be intended as a generic
factory for the writers, but it looks like the adm_writer.py has a different
signature for the function.

http://codereview.chromium.org/3116027/diff/16019/4004#newcode11
tools/grit/grit/format/policy_templates/writers/plist_strings_writer.py:11: 
two blank lines between top-level elements

http://codereview.chromium.org/3116027/diff/16019/4005
File tools/grit/grit/format/policy_templates/writers/plist_writer.py (right):

http://codereview.chromium.org/3116027/diff/16019/4005#newcode11
tools/grit/grit/format/policy_templates/writers/plist_writer.py:11: def
GetWriter(info, messages):
same comment as other file

[gfeher, 2010-08-24 19:03:32]

I tried to fix everything but I guess its not perfect yet. Please take a look at
it.

http://codereview.chromium.org/3116027/diff/16019/4004
File tools/grit/grit/format/policy_templates/writers/plist_strings_writer.py
(right):

http://codereview.chromium.org/3116027/diff/16019/4004#newcode6
tools/grit/grit/format/policy_templates/writers/plist_strings_writer.py:6: from
template_writer import TemplateWriter
On 2010/08/24 15:20:23, Jói wrote:
> GRIT style (and Google style) is to import from the root of the project, and
to
> prefer to import namespaces only, so (since you're only using TemplateWriter
> once) I would recommend
> 
> from grit.format.policy_templates.writers import template_writer

Done.

http://codereview.chromium.org/3116027/diff/16019/4004#newcode9
tools/grit/grit/format/policy_templates/writers/plist_strings_writer.py:9: def
GetWriter(info, messages):
On 2010/08/24 15:20:23, Jói wrote:
> Needs docstring; also it's unclear to me why you need it at all, rather than
> just calling the constructor.  I thought it might be intended as a generic
> factory for the writers, but it looks like the adm_writer.py has a different
> signature for the function.

It is a generic factory, and in adm_writer it should have the same signature. It
is called from policy_template_generator._GetOutput
I guess it is different for you because I have landed a CL this morning (CET)
that has changed the signature.

http://codereview.chromium.org/3116027/diff/16019/4004#newcode11
tools/grit/grit/format/policy_templates/writers/plist_strings_writer.py:11: 
On 2010/08/24 15:20:23, Jói wrote:
> two blank lines between top-level elements

Done.

http://codereview.chromium.org/3116027/diff/16019/4005
File tools/grit/grit/format/policy_templates/writers/plist_writer.py (right):

http://codereview.chromium.org/3116027/diff/16019/4005#newcode11
tools/grit/grit/format/policy_templates/writers/plist_writer.py:11: def
GetWriter(info, messages):
On 2010/08/24 15:20:23, Jói wrote:
> same comment as other file

Done.

[Jói, 2010-08-24 19:28:35]

LGTM++

Groovy!  No need for me to take another look, just the one nit about two +80
character lines.  (I'm OK with the +80 lines that are caused by inlining of XML
in your unit test files)

http://codereview.chromium.org/3116027/diff/42001/1029
File tools/grit/grit/format/policy_templates/writers/writer_unittest_common.py
(right):

http://codereview.chromium.org/3116027/diff/42001/1029#newcode57
tools/grit/grit/format/policy_templates/writers/writer_unittest_common.py:57:
def CompareResult(self, grd, env_lang, env_defs, out_type, out_lang,
expected_output):
+80 (next line as well)